refactor: replace _get_hash_context with direct ->hash_ctx access - #1908
Merged
real-or-random merged 1 commit intoAug 24, 2026
Merged
Conversation
See issue bitcoin-core#1835 ("Follow-ups to bitcoin-core#1777").
theStack
force-pushed
the
nuke-get_hash_context
branch
from
August 24, 2026 05:54
0cdbd2e to
c8745f6
Compare
Contributor
Author
|
Rebased on master to resolve merge conflicts (caused by #1915). |
furszy
reviewed
Aug 24, 2026
macgyver13
added a commit
to macgyver13/secp256k1
that referenced
this pull request
Aug 28, 2026
Implements BIP-374 Discrete Log Equality (DLEQ) proofs as a new module. - Build system integration (CMake, autotools) - Configure dleq module as optional, but enabled in dev mode - Public API header declarations - Internal cryptographic implementation (prove_internal, verify_internal) - Tagged SHA256 functions per BIP-374 specification - Nonce generation following BIP-374 Proof generation and verification both reject infinity points, and the secret-derived buffers (the masked key, the nonce, and the serialized secret scalar a) are cleared before returning. - Rearrange e and s in prove_internal and verify_internal to match serialization order - Arrange dleq_challenge parameters in hash order - Compare the challenge with secp256k1_scalar_eq instead of negate-and- test-for-zero - Use &ctx->hash_ctx directly (bitcoin-core#1908 removed the get_hash_context() accessor) - Pass NULL rather than secp256k1_scalar_zero for the unused G scalar in secp256k1_ecmult (bitcoin-core#1834) Co-authored-by: stratospher <44024636+stratospher@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #1835: #1835 (comment).